update admin channel naming convention

[andrekir]

convention was updated to accept "admin" in any case format (ie. "Admin", "admin", "ADMIN", etc) but python CLI still requires all lowercase "admin" channel name.

[ammarfitwalla]

Hi, can I work on this issue?

[garthvh]

Sure

[pranshugupta01]

Hi , can i work on this issue?
Can you please elaborate it more, and specify particularly where you are facing this issue?

[andrekir]

sure. see: https://meshtastic.org/docs/configuration/remote-admin

[TimothyHarder]

Hi guys, I'm just starting to learn the project so please forgive my simple question.

This seems like a pretty simple change, just calling lower in the ch_add block after the length check, or in the getChannelByName function. Do you all want all channel names cast to lowercase, or is just the admin channel case-insensitive?

[andrekir]

_getAdminChannelIndex needs to find any case-insensitive variant of "admin" like: Admin ADMIN ADmin etc

maybe something like:

def _getAdminChannelIndex(self):
    """Return the channel number of the admin channel, or 0 if no reserved channel"""
    for c in self.channels or []:
        if c.settings and c.settings.name.lower() == "admin":
            return c.index
    return 0

[TimothyHarder]

Definitely a good idea, though I think modifying user input has merit, or we could end up with a channel list like so:
["admin", "Admin", "ADMIN"] and _getAdminChannelIndex would return the first of them. I was thinking the self.channels could be all case insensitive, all added channels would be stored lowercase. Admittedly though, I don't know the project very well yet and wouldn't know the implications of making a change like that.

That said, I've got a PR in with your suggested change for now! #478