Skip to content

Conversation

@prampec
Copy link
Contributor

@prampec prampec commented Feb 21, 2022

See description of PR meshtastic/firmware#1232

Note that protos changes are not part of this commit!

Most of this code changes are made by @mkinney .

@prampec
Copy link
Contributor Author

prampec commented Feb 21, 2022

Also note, that unit tests are not updated/executed by me.

@mkinney
Copy link
Contributor

mkinney commented Feb 26, 2022

Is this PR ok to merge? @prampec

@prampec
Copy link
Contributor Author

prampec commented Feb 26, 2022

It works well. Changes are mostly done by you. My most notable change is on mesh_interface.py. Please verify that.

Unit tests are not altered by me, so you might also want to take a look on that.

@mkinney
Copy link
Contributor

mkinney commented Feb 26, 2022

I just "approved" the work flow. (I must admit that I didn't realize that I needed to do that.)

Can you fix the lint warnings? I think you just need to add "self.Response = None" in the constructor for the most of those warnings. The other warning can be "worked around" by modifying the .pylintrc file "max-module-lines=1200" to something like 1400.

@mkinney
Copy link
Contributor

mkinney commented Feb 26, 2022

Also, do you know what commit of the protobufs is needed for this change?

@mkinney
Copy link
Contributor

mkinney commented Feb 26, 2022

Well, I'm just going to merge this then do a PR to fix the warnings.

@mkinney mkinney merged commit d2ec09e into meshtastic:master Feb 26, 2022
@prampec
Copy link
Contributor Author

prampec commented Feb 26, 2022

I do not know too much about python, and I don't know how to execute these checks locally (pylnt, pytest, coverage, etc.). Please give me more details on the topic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants