Skip to content

Conversation

@rc14193
Copy link
Contributor

@rc14193 rc14193 commented Feb 25, 2024

Motivation and Context

Since the pb2 files are auto generated and shouldn't be manually changed, I think it might be better if they're in their own subfolder. This makes things cleaner and makes it clearer what are the core files of the project.

Description

This is implemented by performing the following:

  • Add a mv command to regen-protobufs to transfer files to PbDefinitions subfolder.
  • Adding an additional sed command to update imports in the pb2 files.
  • Manually updating import calls in other files in the project

Testing

pytest was run on both branches and test results were the same

Pytest on Changes

image

Pytest on Main

image

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2024

CLA assistant check
All committers have signed the CLA.

@thebentern thebentern merged commit 8d6827d into meshtastic:master Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants