Skip to content

Conversation

@ianmcorvidae
Copy link
Contributor

@ianmcorvidae ianmcorvidae commented Mar 14, 2024

Similar to how the web UI shows "UNK: ", this will show that under "User", and the hex ID that can be computed from that under "ID". The change to using self.nodesByNum was necessary to pull in those, since self.nodes only has nodes that have users, which excludes nodes in this particular state.

Fixes #504

Copy link
Contributor

@jp-bennett jp-bennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any unknown nodes to confirm, but the node list looks fine otherwise.

@thebentern thebentern merged commit 6bed30e into meshtastic:master Mar 14, 2024
@ianmcorvidae
Copy link
Contributor Author

Merged already (thanks!), but I should have included what it looks like via my own couple of 'em, so I'll still drop that here:

│  14 │ UNK: 2889340535                  │ !ac37d677 │ N/A   │ N/A        │ N/A         │ N/A        │ N/A       │ N/A             │ N/A            │ 13.25 dB  │       N/A │ 2024-03-02 11:42:26 │ 1 week ago     │
├─────┼──────────────────────────────────┼───────────┼───────┼────────────┼─────────────┼────────────┼───────────┼─────────────────┼────────────────┼───────────┼───────────┼─────────────────────┼────────────────┤
│  15 │ UNK: 2208397066                  │ !83a1770a │ N/A   │ N/A        │ N/A         │ N/A        │ 79%       │ 8.15%           │ 0.50%          │ 10.75 dB  │       N/A │ 2024-03-02 11:41:37 │ 1 week ago     │

@ianmcorvidae ianmcorvidae deleted the unknown-nodes branch March 19, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Show unknown nodes in some fashion in --nodes output

3 participants