feat:506 show all module settings #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Missing fields are omitted. Solution: This fix sets the flag `always_print_fields_with_no_presence` in the invocation of the protobuff method `MessageToJson` will display the missing fields. see: MessageToJson https://github.com/protocolbuffers/protobuf/blob/6b36eb633ccc9c585ed1ead117fca91702814027/python/google/protobuf/json_format.py#L82 see: issue meshtastic#506 meshtastic#506
|
|
|
flavor omission seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
This looks pretty reasonable to me, but we can't merge it without a signed CLA. If you can do that, I think I'd be happy to get this in. |
Contributor
Author
|
The PR should be all set @ianmcorvidae |
Contributor
|
Excellent, thanks for signing that. I'll get this merged in, and thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Missing fields are omitted.
Solution:
This fix sets the flag
always_print_fields_with_no_presencein the invocation of the protobuff methodMessageToJsonwill display the missing fields.see: MessageToJson https://github.com/protocolbuffers/protobuf/blob/6b36eb633ccc9c585ed1ead117fca91702814027/python/google/protobuf/json_format.py#L82
see: issue #506 #506