Skip to content

Conversation

@Travis-L-R
Copy link

Background
The output of export_config() normally omits config values that have been set to false, because most protobuf config settings default to false anyway and therefore don't normally need to be set to false. But because some config values may default to true, PR #807 adjusted things that so that where specified "true default" settings have been set false for the node, then those specified settings will still export as false when using export_config().

The Issue

  • The specified setting for the mqtt module has been included as if MQTTConfig were contained in LocalConfig but it's actually contained in ModuleConfig.
  • This results in "mqtt: encryptionEnabled: false" always being present in the wrong section of the output of --export-config (which will then be ignored by --configure with a warning) and no mention of "mqtt: encryptionEnabled: false" in the correct section when it is set to false.

This adjustment adds a second "true_defaults" variable and set_missing_flags_false() call in relation to ModuleConfig, and sticks the mqtt default there.

@ianmcorvidae
Copy link
Contributor

Good catch! As long as CI doesn't complain this looks good to go to me.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.13%. Comparing base (dbc0101) to head (ccb5305).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   60.12%   60.13%   +0.01%     
==========================================
  Files          24       24              
  Lines        4298     4300       +2     
==========================================
+ Hits         2584     2586       +2     
  Misses       1714     1714              
Flag Coverage Δ
unittests 60.13% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ianmcorvidae ianmcorvidae merged commit 0906fc6 into meshtastic:master Nov 12, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants