Fix/auth token expiry empty field

[KarlsonComplete]

Fix empty data field auth_token_expires_in

[gemini-code-assist]

Summary of Changes

Hello @KarlsonComplete, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the auth_token_expires_in field was not being properly populated in AuthToken instances within test environments. By modifying the Bitrix24AccountBuilder, the AuthToken constructor now includes a calculated expiration timestamp, ensuring more robust and accurate testing of authentication token lifecycles.

Highlights

• AuthToken Expiry Field: The AuthToken constructor in the test builder now explicitly sets the auth_token_expires_in field.
• Test Data Improvement: This change improves the realism of test data by ensuring that generated AuthToken instances include an expiration timestamp.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an empty auth_token_expires_in field by updating the AuthToken instantiation in the Bitrix24AccountBuilder. While this change is a step in the right direction, the fix seems incomplete. The renewAuthToken method in src/Bitrix24Accounts/Entity/Bitrix24Account.php also creates an AuthToken and appears to be missing this update, which could lead to bugs. I recommend a broader review of all AuthToken instantiations. I've also added a small suggestion to improve readability in the modified file.

[gemini-code-assist]

To improve readability and avoid magic numbers, it's better to express time durations as calculations. For example, 3600 can be written as 60 * 60. Additionally, for calculating a day in seconds, the conventional order is from largest to smallest unit, like 24 * 60 * 60.

        $this->authToken = new AuthToken('old_1', 'old_2', 60 * 60, time() + 24 * 60 * 60);