Skip to content

Fix/auth token expiry empty field #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mesilov merged 3 commits into from
Oct 26, 2025
Merged

Fix/auth token expiry empty field #55

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d62642f
Merge pull request #50 from mesilov/dev
mesilov Aug 23, 2025
7860e4d
Merge pull request #54 from mesilov/dev
mesilov Aug 23, 2025
bcf1fcb
Fix empty data in db field auth_token_expires_in
KarlsonComplete Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Functional/Bitrix24Accounts/Builders/Bitrix24AccountBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function __construct()
$this->isBitrix24UserAdmin = true;
$this->memberId = Uuid::v4()->toRfc4122();
$this->domainUrl = Uuid::v4()->toRfc4122().'-example.com';
$this->authToken = new AuthToken('old_1', 'old_2', 3600);
$this->authToken = new AuthToken('old_1', 'old_2', 3600,time() + 60 * 60 * 24);
Copy link

@gemini-code-assist gemini-code-assist bot Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability and avoid magic numbers, it's better to express time durations as calculations. For example, 3600 can be written as 60 * 60. Additionally, for calculating a day in seconds, the conventional order is from largest to smallest unit, like 24 * 60 * 60.

        $this->authToken = new AuthToken('old_1', 'old_2', 60 * 60, time() + 24 * 60 * 60);

$this->applicationVersion = 1;
$this->applicationScope = new Scope();
}
Expand Down