BUG: preserve file permissions for sdist#102
Conversation
|
Ah fun to test - git does not preserve permissions aside from the executable bit. The checkout depends on For installing a wheel, only the executable bit matters, So the bug fix is fine here, but for a robust test it looks like we should only test the executable bit. |
|
@FFY00 would you then prefer this to be a separate test, rather than included in |
|
Yep, I would, but this is acceptable too. |
Permissions on windows don't follow the unix permission model anyway. You probably know this article, and it talks about much, much more than that, but I would just reflect this in the windows tests - or perhaps even better - just test for the main executable bit. |
FFY00
force-pushed
the
file-permissions
branch
4 times, most recently
from
227e7c6 to
e221af6
Compare
FFY00
left a comment
FFY00
left a comment
There was a problem hiding this comment.
Thanks!
I have added a test for the built wheel and skipped the executable bit tests on Windows.
|
thanks! |
Closes mesonbuildgh-82 Signed-off-by: Filipe Laíns <lains@riseup.net>
Note that Meson does have the correct install path in
`intro-install_plan.json`, containing `{bindir}`.
This gets translated into `script/` somewhere, at least for a
conda-installed Python on Arch Linux. This code was added in mesonbuildgh-102,
and it's not quite clear why this line was commented out.
For now, let's just make sure the test is not failing.
Note that Meson does have the correct install path in
`intro-install_plan.json`, containing `{bindir}`.
This gets translated into `script/` somewhere, at least for a
conda-installed Python on Arch Linux. This code was added in mesonbuildgh-102,
and it's not quite clear why this line was commented out.
For now, let's just make sure the test is not failing.
Note that Meson does have the correct install path in
`intro-install_plan.json`, containing `{bindir}`.
This gets translated into `script/` somewhere, at least for a
conda-installed Python on Arch Linux. This code was added in mesonbuildgh-102,
and it's not quite clear why this line was commented out.
For now, let's just make sure the test is not failing.
xref mesonbuildgh-115
Note that Meson does have the correct install path in
`intro-install_plan.json`, containing `{bindir}`.
This gets translated into `script/` somewhere, at least for a
conda-installed Python on Arch Linux. This code was added in gh-102,
and it's not quite clear why this line was commented out.
For now, let's just make sure the test is not failing.
xref gh-115
[ci skip]
3 participants
Closes gh-82
Note that the bug report is only about the sdist. The wheel generation uses
shutil.copy2, which should do the right thing already.