Conversation
e71ab51 to
f9814c5
Compare
|
Also, CI seems to be unhappy. |
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
|
More Mypy buggy-ness: This works fine locally on both Linux and macOS, and the code is correct - just a little complicated with property decorators:( |
The code itself should be fine, but the fixture is having a hard to diagnose issue in CI in the setup phase.
It depends on the exact Mypy version and the minor version of Python ... sigh. On Python 3.9 this error disappears, and another one appears. Guess we have to live with it, Mypy isn't going to mature any time soon. |
|
This was all green modulo the mypy issue, the last commit should fix that. |
|
This is happy, in it goes. Thanks @FFY00! |
|
Thanks for all the work on getting this PR ready for merging. For next time, I'd prefer PRs that do multiple things to be rebase-merged, instead of squashed, the rule I try to abide by is one commit per logical change. In case you are not used to this kind of workflow, I recommend using fixup commits if you need to modify commits, as explained in https://openinput.readthedocs.io/en/latest/contributing/index.html#workflow. Thanks 😊 |
|
Sure, that is a good idea in most cases. I am familiar with it, will aim to rebase-merge where possible. In cases where it would break |
|
Thanks! All commits being self-contained is also something I strive to achieve, so in this workflow you would apply the fixes needed to the PR to each respective commit. |
Closes gh-141