BUG: Fix meson-python failing on installing install_subdirs#147
Merged
rgommers merged 2 commits intomesonbuild:mainfrom Sep 28, 2022
Merged
BUG: Fix meson-python failing on installing install_subdirs#147rgommers merged 2 commits intomesonbuild:mainfrom
rgommers merged 2 commits intomesonbuild:mainfrom
Conversation
rgommers
added a commit
to rgommers/meson-python
that referenced
this pull request
Sep 25, 2022
This works with the fix in mesonbuildgh-147. [ci skip]
rgommers
approved these changes
Sep 25, 2022
Contributor
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Thanks @lithomas1! I have tested that this works with the test case for install_subdir in gh-145.
Contributor
|
Mypy and the pre-commit check seem to be a bit unhappy still. |
rgommers
added a commit
to rgommers/meson-python
that referenced
this pull request
Sep 27, 2022
This works with the fix in mesonbuildgh-147. [ci skip]
rgommers
force-pushed
the
fix-install-subdirs
branch
from
db840d5 to
eb2f731
Compare
Contributor
|
This is happy now, and also works in combination with the scipy-like test in gh-148. So in it goes. Thanks @lithomas1! |
rgommers
added a commit
to rgommers/meson-python
that referenced
this pull request
Sep 28, 2022
This works with the fix in mesonbuildgh-147. [ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can only write a single file, or a directory that you can't specify the destination for with wheel.
I copy pasted the code and adjusted from wheel to do it.
cc @rgommers @FFY00