BUG: also handle macOS 10.X versions correctly #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
force-pushed
the
one-more-macos-tag-fix
branch
from
62bafb2 to
d9e3341
Compare
This is a follow-up to mesonbuildgh-161 Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
one-more-macos-tag-fix
branch
from
d9e3341 to
24b087f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to gh-161. From my review comment there:
However, the logic is wrong for macOS 10.x - there we do want to preserve the major version, it should result in (e.g.)
10_13and not10_0.