Skip to content

Conversation

@Totto16
Copy link
Contributor

@Totto16 Totto16 commented Apr 2, 2025

This is by no means feature complete, I just converted the Makefile + cmake build files to this.

Feel free to suggest changes :)

Linux compilation tested, (Windows and MacOS will be tested by CI) others (cross compile for example) not

NOTE

It was harder to make the examples compile (especially on windows), than the actual library.

There are no tests 😓 , so the examples act as those, since if the compile, at least some things are working correctly

@Totto16 Totto16 force-pushed the add_raylib branch 14 times, most recently from acaa8d7 to b07cd56 Compare April 3, 2025 23:07
@QWERTIOX
Copy link
Contributor

QWERTIOX commented Apr 23, 2025

Git didn't allow me to commit directly to this pr @Totto16 did you allow commits from maintainers? My fixes Totto16#3

@Totto16
Copy link
Contributor Author

Totto16 commented Apr 23, 2025

Git didn't allow me to commit directly to this pr @Totto16 did you allow commits from maintainers? My fixes Totto16#3

I did allow edit by maintainers, but since you are no maintainer of this repo, you can't push to the branch.

I'll look into your PR into this branch-

Thanks for helping out, It worked locally for me, but while trying to fix it for windows I added an error and then I didn't have enough time to fix it again. 😓

@Totto16 Totto16 force-pushed the add_raylib branch 7 times, most recently from 50aca04 to 90f4bec Compare April 27, 2025 00:35
@ivanrg99
Copy link

ivanrg99 commented Jul 5, 2025

any updates on this?

@Totto16
Copy link
Contributor Author

Totto16 commented Jul 5, 2025

any updates on this?

We should ask potential reviewers (maintainers), as I use this wrap already privately, it works for me ™️ , but it also compiles everywhere, so it just needs to be reviewed 😓

Copy link
Collaborator

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a glfw wrap the parent project can install if needed, so we shouldn't support the embedded GLFW at all. It adds a lot of complexity here and reimplements Meson code maintained elsewhere, and also using private copies of library code isn't great.

@Totto16 Totto16 force-pushed the add_raylib branch 3 times, most recently from 532cfdd to 8d26532 Compare October 21, 2025 14:20
@Totto16
Copy link
Contributor Author

Totto16 commented Oct 21, 2025

There's already a glfw wrap the parent project can install if needed, so we shouldn't support the embedded GLFW at all. It adds a lot of complexity here and reimplements Meson code maintained elsewhere, and also using private copies of library code isn't great.

I agree and I removed it, but I left it in for commit #1, so that in the future, if this would be needed, it would be in the git history :)

@Totto16 Totto16 requested a review from bgilbert October 21, 2025 14:21
@Totto16 Totto16 requested a review from neheb November 3, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants