Multi project #108
Multi project #108
Conversation
…new file locations and the correct name of the executor
|
@DarinJ @mohitsoni @adam-mesos @smarella any review here. I would like to merge this, this week. Tomorrow if possible. |
|
Should we distribute: gradle/wrapper/gradle-wrapper.jar? |
|
no... that is not part of the distro... only used for the build process |
|
several people seem confused by the gradle-wrapper.jar and the fact that we have a binary checked into the repo. It is idiomatic gradle code to include it. it is a 25k jar that is a bootstrap jar for pulling the correct version of gradle for the build. It ensures that builds always work because the meta-data for what the correct tool and version for building is included with the project. |
There was a problem hiding this comment.
probably should be consistant with myriad-executor-runnable-0.0.1.jar and myriad-executor-runnable-xxx.jar throughout documentation. That's not on you though.
There was a problem hiding this comment.
ok... I've updated several. here is the rule I followed: 1) if it was documentation / mentioned in docs, it has myriad-executor-runnable-x.x.x.jar, however if 2) it was used in a config file example like yml or part of a shell example I left the myriad-executor-runnable-0.0.1.jar version.
|
During build two warnings about style. +1 for warnings instead of errors, but would be nice if Travis would still complain. |
|
regarding warnings. I was trying to get this PR in with min changes to the project... just the structure. however I will take a look and fix these. |
|
done! @DarinJ what do you think... are we good to merge ? |
|
+1 |
|
@kensipe if you've tested it, I think we're good. I got through the build on a cluster last night, but haven't had a chance to install. I saw no other issues today. |
|
I did some vagrant testing... I think we are good to go! |
large change to build as a multi-project build. It was too much work to rebase the previous PR-77
This is basically the same work however I've updated all the docs now and have tested the vagrant configuration.
Lets get this checked and merged!