Skip to content

Minimal fix: set camera position #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rugeli merged 2 commits into from
Nov 21, 2025
Merged

Minimal fix: set camera position #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b067b9d
set camera
rugeli Nov 13, 2025
4bdf12e
use max dimension
rugeli Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cellpack/autopack/upy/simularium/simularium_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,9 @@ def writeToFile(self, file_name, bb, recipe_name, version):
n_subpoints[t][n] = 0
n += 1

camera_z_position = box_size[2] if box_size[2] > 10 else 100.0
# use max dimension to make sure camera captures entire scene
max_box_dimension = max(box_size)
camera_z_position = max_box_dimension * 2.5
Copy link
Copy Markdown
Collaborator

@mogres mogres Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good workaround! For the future maybe we can reduce this multiplier or have it as a parameter because some of the packings still look too far away. We also can set the camera x position to 0 instead to avoid hard coded numbers.

converted_data = TrajectoryData(
meta_data=MetaData(
box_size=np.array(box_size),
Expand Down
2 changes: 1 addition & 1 deletion cellpack/bin/simularium_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def main():
converter.fill_in_empty_fiber_data(time_point_index)
if converter.debug:
print("SUBPOINTS LENGTH", len(converter.subpoints[time_point_index]))
camera_z_position = box_size[2] if box_size[2] > 10 else 100.0
camera_z_position = box_size[2] * 1.5
converted_data = TrajectoryData(
meta_data=MetaData(
box_size=np.array(box_size),
Expand Down
2 changes: 1 addition & 1 deletion examples/recipes/v2/spheres_in_a_box.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
[
1000,
1000,
1500
1000
]
],
"objects": {
Expand Down
Loading