Skip to content

admin/requirements-update_2026-03-18_17-14_23257457346#458

Merged
mogres merged 1 commit intomainfrom
admin/requirements-update_2026-03-18_17-14_23257457346
Mar 20, 2026
Merged

admin/requirements-update_2026-03-18_17-14_23257457346#458
mogres merged 1 commit intomainfrom
admin/requirements-update_2026-03-18_17-14_23257457346

Conversation

@mogres
Copy link
Copy Markdown
Collaborator

@mogres mogres commented Mar 18, 2026

Updating requirements.txt.

@github-actions
Copy link
Copy Markdown
Contributor

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@mogres mogres requested a review from rugeli March 18, 2026 18:54
Copy link
Copy Markdown
Collaborator

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come to think of it, what's the use case for these files now that we use uv and pyproject.toml? Are we keeping requirements.txt around so the codebase remains pip-compatible for users who don't have uv installed? If that's helpful for users, then it makes sense to keep them, otherwise we could consider deprecating them gradually.

@mogres
Copy link
Copy Markdown
Collaborator Author

mogres commented Mar 19, 2026

Come to think of it, what's the use case for these files now that we use uv and pyproject.toml? Are we keeping requirements.txt around so the codebase remains pip-compatible for users who don't have uv installed? If that's helpful for users, then it makes sense to keep them, otherwise we could consider deprecating them gradually.

Good point @rugeli! The requirements.txt files are not strictly necessary as pip install works with pyproject.toml. However, I think some of our docker workflow and CI uses the pip install workflow reading from the requirements files. How about this:

  1. Merge this PR for now to see if that addresses any of the reported dependabot dependency issues.
  2. We look for and update instances of pip install from requirementes files in the codebase and in the CI to use uv sync or pip install from pyproject.toml instead
  3. We stop tracking the requirements.txt files, and get rid of the automated action that exports them after dependencies change.
  4. Update README.md to reflect the new installation instructions

@mogres mogres requested a review from rugeli March 20, 2026 18:24
Copy link
Copy Markdown
Collaborator

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a plan!

@mogres mogres merged commit 0262651 into main Mar 20, 2026
10 checks passed
@mogres mogres deleted the admin/requirements-update_2026-03-18_17-14_23257457346 branch March 20, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants