Conversation
…ecipe file path from URL
Closed
ascibisz
changed the title
Contributor
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
…references to AWS batch
rugeli
reviewed
May 1, 2026
rugeli
approved these changes
May 1, 2026
Collaborator
rugeli
left a comment
rugeli
left a comment
There was a problem hiding this comment.
only one unused uuid import, otherwise looks great to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When we started supporting a JSON body for a packing request to the server, we wanted to stay backwards compatible and also accept the recipe path as a URL parameter.
Now that we have fully deployed cellpack studio with the change to pass the recipe in the JSON body, we can strip out the support for the URL param way of sending a recipe from server.py
We also don't actually use AWS batch for cellpack server, so I also stripped out the references to batch and the dockerfile we had used in batch