Add timeout option to client methods #13
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a backward-compatible timeout option to each client method.
Without the ability to provide a timeout, requests can hang (I think up to the global max socket timeout in Python).
See: http://docs.python-requests.org/en/master/user/quickstart/#timeouts
Alternatively, a single timeout could be provided when instantiating a
Client. This approach wouldn't require changes to methods other thanrequest. However, given the wide range of methods that the client provides, this more granular timeout may be preferred.Also, I imagine this should be a minor version bump
1.2.1 -> 1.3.0. Let me know if you'd like me to make that change in setup.py as well.