[CLI/ENHANCEMENT] Logging in CLI with rich and isolation #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
2 tasks
zkwentz
approved these changes
Nov 2, 2025
Collaborator
Author
|
thanks for approving @zkwentz . I'll let you merge with your ongoing changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implemntation logs with print statements within the cli's business logic. This can become hard to maintain/debug.
I've implemented this PR which does two things:
__main__for logging long processes with spinner and improved ux on traces__main__.Going forward, if we use this approach, I'd suggest just raise errors and
logginganything for debugging and let__main__hand the user.