Fix torchtitan CI training.compile --> compile.enable #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #124, branch: xmfan/stack/3
meta-cla
bot
added
the
CLA Signed
Contributor
|
The fix was also made in #95. Seems like this causes a merging conflict to the internal test build system. I am not sure how to resolve it internally... |
Member
Author
|
@zpcore the diff looks okay now, did you have to manually rebase? |
Contributor
|
Hi @xmfan , D81270578 failed to rebase, I forced landing the D81270578. The similar failure now passed to D81280732. |
Member
Author
|
i'll check in with devinfra on monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Fix torchtitan CI training.compile --> compile.enable