Skip to content

Whc/knobs #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2025
Merged

Whc/knobs #233

merged 2 commits into from
Nov 6, 2025

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Nov 5, 2025 •
edited
Loading

needs to merge in lock step with pytorch/torchtitan#1994

test jobs launched via python sweep.py --sweep compare_1d_bucketing:

Repo          Hash                                         Is Clean
------------  -------------------------------------------  ----------
fbpkg         torchtitan_conda_prod:latest_conveyor_build  n/a
autoparallel  a633857cc3773bac6d648bb0454249baa44f2c3f     False
torchtitan    0c88d5768991ee173c1a5dc1c0eb520e8b4984bf     True

Name                                             Job ID
-----------------------------------------------  --------------------------
llama3_FSDP_compile                              torchtitan-64-whc-z5jfds
llama3_autop_1d_compile                          torchtitan-64-whc-rgzzm29
llama3_autop_1d_compile_aten_bucket_reorder      torchtitan-64-whc-p1krq0ng
llama3_autop_1d_compile_inductor_bucket_reorder  torchtitan-64-whc-rhfh6k

tbm command:

tbm llama3_FSDP_compile:torchtitan-64-whc-z5jfds llama3_autop_1d_compile:torchtitan-64-whc-rgzzm29 llama3_autop_1d_compile_aten_bucket_reorder:torchtitan-64-whc-p1krq0ng llama3_autop_1d_compile_inductor_bucket_reorder:torchtitan-64-whc-rhfh6k

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 5, 2025
@wconstab wconstab mentioned this pull request Nov 5, 2025
Merged
ruisizhang123
ruisizhang123 approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@ruisizhang123 ruisizhang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

wconstab added a commit to pytorch/torchtitan that referenced this pull request Nov 6, 2025
@wconstab
Whc/knobs (#1994)
c6e25bd 
needs to merge in lock step with
meta-pytorch/autoparallel#233
@wconstab wconstab merged commit 68c8a07 into main Nov 6, 2025
6 checks passed
@fmassa fmassa deleted the whc/knobs branch November 7, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruisizhang123 ruisizhang123 ruisizhang123 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wconstab @ruisizhang123