Skip to content

Conversation

@Balandat
Copy link
Contributor

We do some grepping magic to extract the versions from botorch.egg-info/requires.txt after running python setup.py egg_info. This was not properly working when pinning a version to an exact match. This fixes that by allowing both >= and == version specification in the grep rexexp.

We do some grepping magic to extract the versions from `botorch.egg-info/requires.txt` after running `python setup.py egg_info`. This was not properly working when pinning a version to an exact match. This fixes that by allowing both `>=` and `==` version specification in the grep rexexp.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 10, 2022
@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Balandat
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1492 (7f0892b) into main (1484c89) will not change coverage.
The diff coverage is n/a.

❗ Current head 7f0892b differs from pull request most recent head c63305e. Consider uploading reports for the commit c63305e to get more accurate results

@@            Coverage Diff            @@
##              main     #1492   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          134       134           
  Lines        12403     12403           
=========================================
  Hits         12403     12403           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@saitcakmak saitcakmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@saitcakmak
Copy link
Contributor

Looks like the tutorials workflow also needs to be updated

@Balandat
Copy link
Contributor Author

Yup, already done, new test run: https://github.com/pytorch/botorch/actions/runs/3439212041

@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@saitcakmak saitcakmak deleted the fix_stable_GHA_workflow branch November 10, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants