-
Notifications
You must be signed in to change notification settings - Fork 458
Fix test_stable GHA workflow #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We do some grepping magic to extract the versions from `botorch.egg-info/requires.txt` after running `python setup.py egg_info`. This was not properly working when pinning a version to an exact match. This fixes that by allowing both `>=` and `==` version specification in the grep rexexp.
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #1492 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 134 134
Lines 12403 12403
=========================================
Hits 12403 12403 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
saitcakmak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
|
Looks like the tutorials workflow also needs to be updated |
|
Yup, already done, new test run: https://github.com/pytorch/botorch/actions/runs/3439212041 |
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
We do some grepping magic to extract the versions from
botorch.egg-info/requires.txtafter runningpython setup.py egg_info. This was not properly working when pinning a version to an exact match. This fixes that by allowing both>=and==version specification in the grep rexexp.