Properly pass noise levels to GPs with FixedNoiseGaussianLikelihood #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@Balandat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…eta-pytorch#241) Summary: Fixes an issue where some models with `FixedNoiseGaussianLikelihood` (e.g. `FixedNoiseGP`) did not properly evaluate the posterior with observation noise. Depends on cornellius-gp/gpytorch#841 Also silences and catches some warnings in the tests. Pull Request resolved: meta-pytorch#241 Test Plan: Unit tests Reviewed By: danielrjiang Differential Revision: D16881331 Pulled By: Balandat fbshipit-source-id: 0356a25b4cd838ac8c78f9820986e7472381de72
Balandat
force-pushed
the
fix_fixed_noise
branch
from
15b70e6 to
f796688
Compare
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 63 63
Lines 2291 2296 +5
=====================================
+ Hits 2291 2296 +5
Continue to review full report at Codecov.
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where some models with
FixedNoiseGaussianLikelihood(e.g.FixedNoiseGP) did not properly evaluate the posterior with observation noise.Depends on cornellius-gp/gpytorch#841
Also silences and catches some warnings in the tests.