Use nanmean and nanstd in Standardize #3072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: Replaced `mean` and `std` with `nanmean` and `nanstd` (respectively) to improve robustness (and matching `StratifiedStandardize`). Also fixed a small bug in `nanstd` which caused the returned shapes to be incorrect if `keepdim=False`. Note: The random seed in `test_transforms` in `test_fully_bayesian_multitask.py` was changed because the previous seed caused the test to fail on a single element due to randomness. Differential Revision: D86318672
jandylin
force-pushed
the
export-D86318672
branch
from
4247eaa to
b0eabe6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 217 217
Lines 20736 20736
=========================================
Hits 20736 20736 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 40bb460. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replaced
meanandstdwithnanmeanandnanstd(respectively) for improvement robustness (and matchingStratifiedStandardize). Also fixed a small bug innanstdwhich caused the returned shapes to be incorrect ifkeepdim=False.Note: The random seed in
test_transformsintest_fully_bayesian_multitask.pywas changed because the previous seed caused the test to fail on a single element due to randomness.Differential Revision: D86318672