sampler: allow specification of a range of batch dims to collapse #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21993666 |
…ta-pytorch#457) Summary: Pull Request resolved: meta-pytorch#457 see title; motivated need for different base samples in qMS within tree Reviewed By: Balandat Differential Revision: D21993666 fbshipit-source-id: 1e9bd7a15bf8f2f772bbc16ca84dde98d5cbaf9b
danielrjiang
force-pushed
the
export-D21993666
branch
from
b4da66a to
226b11b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21993666 |
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 72 72
Lines 4328 4348 +20
=========================================
+ Hits 4328 4348 +20
Continue to review full report at Codecov.
|
Contributor
|
This pull request has been merged in e7df3da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: see title; motivated need for different base samples in qMS within tree
Reviewed By: Balandat
Differential Revision: D21993666