pass feasibility to _pad_batch_pareto_frontier #661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25786536 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25786536 |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jan 11, 2021
Summary: Pull Request resolved: meta-pytorch#661 see title. Passing a feasibility mask is useful when we have constraints because the feasible tensors may have different sizes in each batch Reviewed By: Balandat Differential Revision: D25786536 fbshipit-source-id: ed7a3872767d3455603cbae36dc05e2a19ff5384
sdaulton
force-pushed
the
export-D25786536
branch
from
936bc87 to
50d7204
Compare
…ructure (meta-pytorch#656) Summary: Pull Request resolved: meta-pytorch#656 see title. This will tidy things up for future additions. This also requires that a reference point is specified upon initialization. Differential Revision: D25725167 fbshipit-source-id: 05ec45415063de5c0ac06b64476fd43d00500cfe
Summary: Pull Request resolved: meta-pytorch#657 see title. Before there could be duplicates in the pareto set. Differential Revision: D25753915 fbshipit-source-id: bd000653f7b02b402328df17dc3f3c9ec2dfd7b9
Summary: Pull Request resolved: meta-pytorch#658 see title. This also handles the edge case of zero points on the pareto frontier Differential Revision: D25738677 fbshipit-source-id: 3998c2c967e35296cd09cbefe40af827c5ddff45
Summary: Pull Request resolved: meta-pytorch#661 see title. Passing a feasibility mask is useful when we have constraints because the feasible tensors may have different sizes in each batch Reviewed By: Balandat Differential Revision: D25786536 fbshipit-source-id: 180b7800ab3f6cf7c0837f85e7430c1d383dd853
sdaulton
force-pushed
the
export-D25786536
branch
from
50d7204 to
0d3a951
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25786536 |
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 93 97 +4
Lines 6480 6541 +61
=========================================
+ Hits 6480 6541 +61
Continue to review full report at Codecov.
|
Contributor
|
This pull request has been merged in aebf61f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: see title. Passing a feasibility mask is useful when we have constraints because the feasible tensors may have different sizes in each batch
Reviewed By: Balandat
Differential Revision: D25786536