Skip to content

Conversation

@seemethere
Copy link
Contributor

To release compatible binaries for PyTorch 1.7

Signed-off-by: Eli Uriegas eliuriegas@fb.com

To release compatible binaries for PyTorch 1.7

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere seemethere requested a review from a team October 30, 2020 20:22
Copy link

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! why does the version become 0.1.3 instead of 0.1.1 though?

@seemethere
Copy link
Contributor Author

seemethere commented Oct 30, 2020

based on the releases I see @pbelevich has already released a 0.1.1 as well as a 0.1.2 so I went with the next bump

NOTE: The version number that's in the .circleci/config.yml doesn't really matter since the binaries are based on the CIRCLE_TAG aka the git tag, it's more just for show

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release/0.1@dc42a5c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.1       #79   +/-   ##
===============================================
  Coverage               ?   100.00%           
===============================================
  Files                  ?         1           
  Lines                  ?         3           
  Branches               ?         0           
===============================================
  Hits                   ?         3           
  Misses                 ?         0           
  Partials               ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc42a5c...26e4035. Read the comment docs.

@seemethere seemethere merged commit a90d461 into meta-pytorch:release/0.1 Oct 30, 2020
@seemethere seemethere deleted the bump_0_1_3 branch October 30, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants