torchcsprng.encrypt/torchcsprng.decrypt with AES128 ECB/CTR support #83

pbelevich · 2020-11-14T19:39:52Z

This PR introduces two new methods to torchcsprng module:

torchcsprng.encrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)

input tensor can be any CPU or CUDA tensor of any dtype and size in bytes(zero-padding is used to make its size in bytes divisible by block size in bytes)

output tensor can have any dtype and the same device as input tensor and the size in bytes rounded to the block size in bytes(16 bytes for AES 128)

key tensor can have any dtype and the same device as input tensor and size in bytes equal to 16 for AES 128

cipher currently can be only one supported value "aes128"

mode currently can be either "ecb" or "ctr"

torchcsprng.decrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)

input tensor can be any CPU or CUDA tensor of any dtype with size in bytes divisible by the block size in bytes(16 bytes for AES 128)

output tensor can have any dtype but the same device as input tensor and the same size in bytes as input tensor

key tensor can have any dtype and the same device as input tensor and size in bytes equal to 16 for AES 128

cipher currently can be only one supported value "aes128"

mode currently can be either "ecb" or "ctr"

Also this PR unifies encryption/decryption with existing random number generation which uses AES128 in CTR mode

Fixes #77

Stack from ghstack:

torchcsprng.encrypt/torchcsprng.decrypt with AES128 ECB/CTR support #83 torchcsprng.encrypt/torchcsprng.decrypt with AES128 ECB/CTR support

Differential Revision: D25080624

[ghstack-poisoned]

ghstack-source-id: 8e814a1 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 55c9a76 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 8c88890 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: ff69f4d Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: e8d2053 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 2f481a1 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: f7af3bb Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 3a26482 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: d0fc3f7 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: ebbc944 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 0366942 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: b2ebdb4 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 2d50967 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: e04d026 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 07d63ea Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 3ee186d Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: 1f1e995 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: b32cd72 Pull Request resolved: #83

[ghstack-poisoned]

ghstack-source-id: dc20a35 Pull Request resolved: #83

…R support" This PR introduces two new methods to `torchcsprng` module: * `torchcsprng.encrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype and size in bytes(zero-padding is used to make its size in bytes divisible by block size in bytes) > - `output` tensor can have any dtype and the same device as `input` tensor and the size in bytes rounded to the block size in bytes(16 bytes for AES 128) > - `key` tensor can be any CPU or CUDA tensor of any dtype and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) * `torchcsprng.decrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype with size in bytes divisible by the block size in bytes(16 bytes for AES 128) > - `output` tensor can have any dtype but the same device as `input` tensor and the same size in bytes as `input` tensor > - `key` tensor can be any CPU or CUDA tensor of any dtype and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) Also this PR unifies encryption/decryption with existing random number generation which uses AES128 in CTR mode Fixes #77 [ghstack-poisoned]

ghstack-source-id: 25f08dc Pull Request resolved: #83

…R support" This PR introduces two new methods to `torchcsprng` module: * `torchcsprng.encrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype and size in bytes(zero-padding is used to make its size in bytes divisible by block size in bytes) > - `output` tensor can have any dtype and the same device as `input` tensor and the size in bytes rounded to the block size in bytes(16 bytes for AES 128) > - `key` tensor can be any CPU or CUDA tensor of any dtype and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) * `torchcsprng.decrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype with size in bytes divisible by the block size in bytes(16 bytes for AES 128) > - `output` tensor can have any dtype but the same device as `input` tensor and the same size in bytes as `input` tensor > - `key` tensor can be any CPU or CUDA tensor of any dtype and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) Also this PR unifies encryption/decryption with existing random number generation which uses AES128 in CTR mode Fixes #77 [ghstack-poisoned]

ghstack-source-id: 614b309 Pull Request resolved: #83

LaRiffle

This is perfect for me!

LaRiffle · 2020-11-19T07:42:15Z

torchcsprng/csrc/block_cipher.h

+//  TORCH_CHECK((input_numel * input_type_size + block_size - 1) / block_size * block_size == output_numel * output_type_size, "wrong size");
+
+//  const auto size_in_bytes = input_numel * input_type_size;
+//  const auto size_in_bytes = output_numel * output_type_size;
+
+  if (device.type() == at::kCPU) {
+//    const auto total = (size_in_bytes + block_size - 1) / block_size;
+//    const auto total = (size_in_bytes + block_size / N - 1) / block_size * N;


We can probably remove these commented lines

LaRiffle · 2020-11-19T07:44:32Z

torchcsprng/csrc/block_cipher.h

+}
+
+template<int block_size, typename cipher_t>
+void block_cipher(Tensor input, Tensor output, cipher_t cipher) {


Maybe we should make sure that 2 functions are not named block_cipher ? (see l.127 above)

I think it's ok, since they are overloaded functions of the same functionality

LaRiffle · 2020-11-19T07:48:30Z

torchcsprng/csrc/csprng.h

+  if (gen->key().defined()) {
+    return gen->key().clone();
+  }
+  auto t = torch::empty({static_cast<signed long>(block_t_size)}, torch::kUInt8);


suggestion: rename t -> key

LaRiffle · 2020-11-19T07:49:28Z

torchcsprng/csrc/csprng.h

+    return gen->key().clone();
+  }
+  auto t = torch::empty({static_cast<signed long>(block_t_size)}, torch::kUInt8);
+  using random_t = uint32_t;


maybe we can fix using uint32_t if it's ok?

gen->random(); will always output 32 bits?

replaced with typename std::result_of<decltype(&RNG::random)(RNG)>::type;

…R support" This PR introduces two new methods to `torchcsprng` module: * `torchcsprng.encrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype and size in bytes(zero-padding is used to make its size in bytes divisible by block size in bytes) > - `output` tensor can have any dtype and the same device as `input` tensor and the size in bytes rounded to the block size in bytes(16 bytes for AES 128) > - `key` tensor can have any dtype and the same device as `input` tensor and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) * `torchcsprng.decrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype with size in bytes divisible by the block size in bytes(16 bytes for AES 128) > - `output` tensor can have any dtype but the same device as `input` tensor and the same size in bytes as `input` tensor > - `key` tensor can have any dtype and the same device as `input` tensor and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) Also this PR unifies encryption/decryption with existing random number generation which uses AES128 in CTR mode Fixes #77 Differential Revision: [D25080624](https://our.internmc.facebook.com/intern/diff/D25080624) [ghstack-poisoned]

ghstack-source-id: bd3f791 Pull Request resolved: #83

pbelevich · 2020-11-20T17:29:09Z

blocked by pytorch/pytorch#48257

…R support" This PR introduces two new methods to `torchcsprng` module: * `torchcsprng.encrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype and size in bytes(zero-padding is used to make its size in bytes divisible by block size in bytes) > - `output` tensor can have any dtype and the same device as `input` tensor and the size in bytes rounded to the block size in bytes(16 bytes for AES 128) > - `key` tensor can have any dtype and the same device as `input` tensor and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) * `torchcsprng.decrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype with size in bytes divisible by the block size in bytes(16 bytes for AES 128) > - `output` tensor can have any dtype but the same device as `input` tensor and the same size in bytes as `input` tensor > - `key` tensor can have any dtype and the same device as `input` tensor and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) Also this PR unifies encryption/decryption with existing random number generation which uses AES128 in CTR mode Fixes #77 Differential Revision: [D25080624](https://our.internmc.facebook.com/intern/diff/D25080624) [ghstack-poisoned]

ghstack-source-id: c7cca30 Pull Request resolved: #83

facebook-github-bot · 2020-11-30T21:06:23Z

@pbelevich merged this pull request in d313741.

…#83) Summary: Pull Request resolved: meta-pytorch/csprng#83 This PR introduces two new methods to `torchcsprng` module: * `torchcsprng.encrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype and size in bytes(zero-padding is used to make its size in bytes divisible by block size in bytes) > - `output` tensor can have any dtype and the same device as `input` tensor and the size in bytes rounded to the block size in bytes(16 bytes for AES 128) > - `key` tensor can be any CPU or CUDA tensor of any dtype and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) * `torchcsprng.decrypt(input: Tensor, output: Tensor, key: Tensor, cipher: string, mode: string)` > - `input` tensor can be any CPU or CUDA tensor of any dtype with size in bytes divisible by the block size in bytes(16 bytes for AES 128) > - `output` tensor can have any dtype but the same device as `input` tensor and the same size in bytes as `input` tensor > - `key` tensor can be any CPU or CUDA tensor of any dtype and size in bytes equal to 16 for AES 128 > - `cipher` currently can be only one supported value `"aes128"` > - `mode` currently can be either [`"ecb"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Electronic_codebook_(ECB)) or [`"ctr"`](https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_(CTR)) Also this PR unifies encryption/decryption with existing random number generation which uses AES128 in CTR mode Fixes #77 Test Plan: Imported from OSS Reviewed By: malfet Differential Revision: D25080624 Pulled By: pbelevich fbshipit-source-id: 00cb7765a02c0320e223dea9fefcb8e57e331f3f

encrypt/decrypt

1857d6f

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 14, 2020

encrypt/decrypt

a61066e

ghstack-source-id: 8e814a1 Pull Request resolved: #83

facebook-github-bot added the Merged label Nov 14, 2020

Update on "encrypt/decrypt"

1737f81

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 16, 2020

encrypt/decrypt

3702aab

ghstack-source-id: 55c9a76 Pull Request resolved: #83

Update on "encrypt/decrypt"

e4955f7

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

9b4e117

ghstack-source-id: 8c88890 Pull Request resolved: #83

Update on "encrypt/decrypt"

583fb80

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

9cf4043

ghstack-source-id: ff69f4d Pull Request resolved: #83

Update on "encrypt/decrypt"

66b2e55

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

3fa2c61

ghstack-source-id: e8d2053 Pull Request resolved: #83

Update on "encrypt/decrypt"

6bd0030

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

3477969

ghstack-source-id: 2f481a1 Pull Request resolved: #83

Update on "encrypt/decrypt"

7465ef1

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

22f9098

ghstack-source-id: f7af3bb Pull Request resolved: #83

Update on "encrypt/decrypt"

247ca74

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

18396b1

ghstack-source-id: 3a26482 Pull Request resolved: #83

Update on "encrypt/decrypt"

f6a260a

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

5c7ebe4

ghstack-source-id: d0fc3f7 Pull Request resolved: #83

Update on "encrypt/decrypt"

9cbd83f

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

4191581

ghstack-source-id: ebbc944 Pull Request resolved: #83

Update on "encrypt/decrypt"

5ae1104

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

ae10238

ghstack-source-id: 0366942 Pull Request resolved: #83

Update on "encrypt/decrypt"

1ea4090

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

8b39912

ghstack-source-id: b2ebdb4 Pull Request resolved: #83

Update on "encrypt/decrypt"

a040964

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

effdcaa

ghstack-source-id: 2d50967 Pull Request resolved: #83

Update on "encrypt/decrypt"

2ae9d3e

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 18, 2020

encrypt/decrypt

3b5eba8

ghstack-source-id: e04d026 Pull Request resolved: #83

Update on "encrypt/decrypt"

cb7d77b

[ghstack-poisoned]

Update on "encrypt/decrypt"

caefc34

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 19, 2020

encrypt/decrypt

8fda986

ghstack-source-id: 07d63ea Pull Request resolved: #83

Update on "encrypt/decrypt"

71e00c3

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 19, 2020

encrypt/decrypt

4eaef7c

ghstack-source-id: 3ee186d Pull Request resolved: #83

Update on "encrypt/decrypt"

9469ece

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 19, 2020

encrypt/decrypt

f4b4c32

ghstack-source-id: 1f1e995 Pull Request resolved: #83

Update on "encrypt/decrypt"

8b01c56

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 19, 2020

encrypt/decrypt

5317f2f

ghstack-source-id: b32cd72 Pull Request resolved: #83

Update on "encrypt/decrypt"

7f91368

[ghstack-poisoned]

pbelevich added a commit that referenced this pull request Nov 19, 2020

encrypt/decrypt

2ba0d39

ghstack-source-id: dc20a35 Pull Request resolved: #83

pbelevich changed the title ~~encrypt/decrypt~~ torchcsprng.encrypt/torchcsprng.decrypt with AES128 ECB and CTR support Nov 19, 2020

pbelevich changed the title ~~torchcsprng.encrypt/torchcsprng.decrypt with AES128 ECB and CTR support~~ torchcsprng.encrypt/torchcsprng.decrypt with AES128 ECB/CTR support Nov 19, 2020

pbelevich requested a review from LaRiffle November 19, 2020 03:02

pbelevich added a commit that referenced this pull request Nov 19, 2020

encrypt/decrypt

4d200f1

ghstack-source-id: 25f08dc Pull Request resolved: #83

pbelevich added a commit that referenced this pull request Nov 19, 2020

encrypt/decrypt

7a06728

ghstack-source-id: 614b309 Pull Request resolved: #83

LaRiffle approved these changes Nov 19, 2020

View reviewed changes

pbelevich added a commit that referenced this pull request Nov 19, 2020

encrypt/decrypt

be87cc7

ghstack-source-id: bd3f791 Pull Request resolved: #83

pbelevich added a commit that referenced this pull request Nov 30, 2020

encrypt/decrypt

2bcb8cc

ghstack-source-id: c7cca30 Pull Request resolved: #83

facebook-github-bot closed this in d313741 Nov 30, 2020

facebook-github-bot added the Merged label Nov 30, 2020

facebook-github-bot deleted the gh/pbelevich/45/head branch December 4, 2020 15:17

pbelevich mentioned this pull request Dec 9, 2020

[Feature Request] Add API support for getting the intial 128bit key used by AES #43

Closed

torchcsprng.encrypt/torchcsprng.decrypt with AES128 ECB/CTR support #83

torchcsprng.encrypt/torchcsprng.decrypt with AES128 ECB/CTR support #83

Uh oh!

Conversation

pbelevich commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LaRiffle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pbelevich commented Nov 20, 2020

Uh oh!

facebook-github-bot commented Nov 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pbelevich commented Nov 14, 2020 •

edited

Loading