Refactor resizeImage function for better resource handling#218
Merged
psiddh merged 2 commits intometa-pytorch:mainfrom Feb 25, 2026
Merged
Refactor resizeImage function for better resource handling#218psiddh merged 2 commits intometa-pytorch:mainfrom
psiddh merged 2 commits intometa-pytorch:mainfrom
Conversation
Refactor image resizing to use input stream safely and improve bitmap scaling.
meta-cla
bot
added
the
CLA Signed
There was a problem hiding this comment.
Pull request overview
This PR refactors the resizeImage function in the ETImage class to improve resource handling and reduce memory consumption by approximately 47 MB per image, preventing out-of-memory errors in Android image processing.
Changes:
- Fixed typo in error message ("input streams" → "input stream")
- Wrapped input stream handling with Kotlin's
.useextension for automatic resource cleanup - Added bitmap recycling for the original bitmap after scaling
- Changed bitmap scaling filter from
falsetotrueto enable bilinear filtering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
llm/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/ETImage.kt
Show resolved
Hide resolved
kirklandsign
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor image resizing to use input stream safely and improve bitmap scaling.
This fix saves ~47 MB of memory per image and prevents an OOM kill, but has zero impact on latency or throughput.
More of stability fix, not a performance fix.