Skip to content

add metatls-hostname to supported enable_transport #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add metatls-hostname to supported enable_transport #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/monarch/_src/actor/actor_mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,12 +392,15 @@ def enable_transport(transport: "ChannelTransport | str") -> None:

Currently only one transport type may be enabled at one time.
In the future we may allow multiple to be enabled.

For Meta usage, use metatls-hostname
"""
if isinstance(transport, str):
transport = {
"tcp": ChannelTransport.TcpWithHostname,
"ipc": ChannelTransport.Unix,
"metatls": ChannelTransport.MetaTlsWithIpV6,
"metatls-hostname": ChannelTransport.MetaTlsWithHostname,
}.get(transport)
if transport is None:
raise ValueError(f"unknown transport: {transport}")
Expand Down
5 changes: 1 addition & 4 deletions python/monarch/_src/job/meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@
from monarch._src.actor.allocator import AllocateMixin
from monarch._src.actor.host_mesh import host_mesh_from_alloc
from monarch._src.actor.meta.allocator import (
MastAllocatorBase,
MastAllocatorConfig,
MastHostAllocator,
MastHostAllocatorBase,
)

from monarch._src.job.job import BatchJob, enable_transport, JobState, JobTrait
from monarch._src.job.job import BatchJob, JobState, JobTrait

from monarch.tools.commands import create, info, kill
from monarch.tools.components.meta import hyperactor
Expand All @@ -40,8 +39,6 @@
from torchx.specs import AppState
from torchx.specs.fb.component_helpers import Packages

enable_transport("metatls")


class _MASTSpec(NamedTuple):
hpcIdentity: str
Expand Down
Loading