Make v0 and v1 ControllerController.get_or_spawn have compatible signatures #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atures Summary: The v0 and v1 ControllerController.get_or_spawn endpoints need to have matching signatures. v1 added a "self_ref" for the actor mesh. v0 doesn't need it but can easily get it and not use it. Differential Revision: D85068507
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85068507. |
|
This pull request has been merged in eca0bc1. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
…atures (meta-pytorch#1621) Summary: Pull Request resolved: meta-pytorch#1621 The v0 and v1 ControllerController.get_or_spawn endpoints need to have matching signatures. v1 added a "self_ref" for the actor mesh. v0 doesn't need it but can easily get it and not use it. Reviewed By: samlurye Differential Revision: D85068507 fbshipit-source-id: b839c2bca2efcd7b285b521ab46ebb1da870af06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The v0 and v1 ControllerController.get_or_spawn endpoints need to have matching
signatures. v1 added a "self_ref" for the actor mesh. v0 doesn't need it but can easily get it and
not use it.
Differential Revision: D85068507