Skip to content

Make v0 and v1 ControllerController.get_or_spawn have compatible signatures #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make v0 and v1 ControllerController.get_or_spawn have compatible signatures #1621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions python/monarch/_src/actor/proc_mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,12 @@ def __init__(self) -> None:
# pyre-ignore
@endpoint
def get_or_spawn(
self, name: str, Class: Type[_ActorType], *args: Any, **kwargs: Any
self,
self_ref: "_ControllerControllerV0",
name: str,
Class: Type[_ActorType],
*args: Any,
**kwargs: Any,
) -> _ActorType:
if name not in self._controllers:
proc_mesh = _proc_mesh_from_allocator(
Expand Down Expand Up @@ -910,9 +915,8 @@ def get_or_spawn_controller_v0(
Returns:
A Future that resolves to a reference to the actor.
"""
return context().actor_instance._controller_controller.get_or_spawn.call_one(
name, Class, *args, **kwargs
)
cc = context().actor_instance._controller_controller
return cc.get_or_spawn.call_one(cc, name, Class, *args, **kwargs)


if v1_enabled or TYPE_CHECKING:
Expand Down