Enhance logging message when supervision events are not handled #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In cases where a supervision event happens very early in a proc lifecycle, before the ProcMeshAgent sets the coordinator port, we end up dropping the event details. Add these to logs so they are seen. Before we would see: ``` proc tcp:hostname:port,service: could not propagate supervision event: coordinator port is not set for proc tcp:hostname:port,service: crashing ``` Now we will also see the original supervision event which caused that crash. Differential Revision: D85676924
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85676924. |
|
This pull request has been merged in 86fba83. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
…-pytorch#1685) Summary: Pull Request resolved: meta-pytorch#1685 In cases where a supervision event happens very early in a proc lifecycle, before the ProcMeshAgent sets the coordinator port, we end up dropping the event details. Add these to logs so they are seen. Before we would see: ``` proc tcp:hostname:port,service: could not propagate supervision event: coordinator port is not set for proc tcp:hostname:port,service: crashing ``` Now we will also see the original supervision event which caused that crash. Reviewed By: amirafzali Differential Revision: D85676924 fbshipit-source-id: 9c3f694be1b9dc25a51728ac313e4504482121e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In cases where a supervision event happens very early in a proc lifecycle, before the
ProcMeshAgent sets the coordinator port, we end up dropping the event details.
Add these to logs so they are seen.
Before we would see:
Now we will also see the original supervision event which caused that crash.
Differential Revision: D85676924