[monarch] Clean future cancellation handling #1687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. Differential Revision: [D85693875](https://our.internmc.facebook.com/intern/diff/D85693875/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85693875/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 28, 2025
The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. Differential Revision: [D85693875](https://our.internmc.facebook.com/intern/diff/D85693875/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85693875/)! ghstack-source-id: 319296138 Pull Request resolved: #1687
meta-cla
bot
added
the
CLA Signed
The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. Differential Revision: [D85693875](https://our.internmc.facebook.com/intern/diff/D85693875/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85693875/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 28, 2025
Pull Request resolved: #1687 The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. ghstack-source-id: 319301656 @exported-using-ghexport Differential Revision: [D85693875](https://our.internmc.facebook.com/intern/diff/D85693875/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85693875/)!
The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. Differential Revision: [D85693875](https://our.internmc.facebook.com/intern/diff/D85693875/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85693875/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 28, 2025
Pull Request resolved: #1687 The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. ghstack-source-id: 319328566 @exported-using-ghexport Differential Revision: [D85693875](https://our.internmc.facebook.com/intern/diff/D85693875/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85693875/)!
The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. Differential Revision: [D85693875](https://our.internmc.facebook.com/intern/diff/D85693875/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85693875/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 29, 2025
Pull Request resolved: #1687 The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. ghstack-source-id: 319407775 @exported-using-ghexport Differential Revision: [D85693875](https://our.internmc.facebook.com/intern/diff/D85693875/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85693875/)!
|
This pull request has been merged in dd2fe54. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: meta-pytorch#1687 The implementation of `monarch.actor.Future` uses `loop.call_soon_threadsafe` to set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future before `call_soon_threadsafe` executes the callback, then `asyncio.exceptions.InvalidStateError` will be logged, which is noisy and misleading. This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback. ghstack-source-id: 319407775 exported-using-ghexport Reviewed By: zdevito Differential Revision: D85693875 fbshipit-source-id: eb515cd65e78fcbb853909af3ba96196c1315c98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The implementation of
monarch.actor.Futureusesloop.call_soon_threadsafeto set a value/exception on an underlying asyncio future. But if the caller cancelled the asyncio future beforecall_soon_threadsafeexecutes the callback, thenasyncio.exceptions.InvalidStateErrorwill be logged, which is noisy and misleading.This diff solves the issue by checking whether the future is already resolved/cancelled from inside the callback.
Differential Revision: D85693875
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!