Do not hold GIL during tokio shutdown #1696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holding the GIL during shutdown of tokio means that any other tokio thread currently waiting on the GIL will never shutdown, which leads to a bad exit later in the shutdown when the TLS state for the python interpreter is gone. Differential Revision: [D85812337](https://our.internmc.facebook.com/intern/diff/D85812337/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85812337/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Oct 29, 2025
Holding the GIL during shutdown of tokio means that any other tokio thread currently waiting on the GIL will never shutdown, which leads to a bad exit later in the shutdown when the TLS state for the python interpreter is gone. Differential Revision: [D85812337](https://our.internmc.facebook.com/intern/diff/D85812337/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85812337/)! ghstack-source-id: 319656538 Pull Request resolved: #1696
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 6265464. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: meta-pytorch#1696 Holding the GIL during shutdown of tokio means that any other tokio thread currently waiting on the GIL will never shutdown, which leads to a bad exit later in the shutdown when the TLS state for the python interpreter is gone. ghstack-source-id: 319656538 exported-using-ghexport Reviewed By: samlurye, mariusae Differential Revision: D85812337 fbshipit-source-id: 4421d5ad47339acb5bb66272e4c5d16595064427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Holding the GIL during shutdown of tokio means that any other tokio thread currently waiting on the GIL will never shutdown, which leads to a bad exit later in the shutdown when the TLS state for the python interpreter is gone.
Differential Revision: D85812337
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!