Remove unused_return_channel in tests #1763
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@thedavekwon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85396555. |
Summary: Refactor so that caller does not have to maintain additional error handling. Differential Revision: D84834014
Summary: use `post` instead if you don't need to subscribe to return channel Differential Revision: D85396555
thedavekwon
force-pushed
the
export-D85396555
branch
from
33d8bc0 to
8635f44
Compare
|
This pull request has been merged in b598138. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: use
postinstead if you don't need to subscribe to return channelDifferential Revision: D85396555