Version guard for AccumulateGrad::add #1768
Closed
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When running `fbpkg build //monarch:monarch_dev` on 3279935a10 we encounter a compile time error that seems to stem from compiling with different versions of PyTorch. We might want to update our build chain. It seems monarch is once compiled against a third part 2.8.0 pytorch and once against the fbcode version. This version guard helps with this version drift if that's intended. Reviewed By: pzhan9, zdevito, soulitzer Differential Revision: D86363543
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 395baba. |
| DEBUG_PRINT( | ||
| "// add: " << node->node->name() | ||
| << ", input_nr=" << static_cast<int>(input_nr) << "\n"); | ||
| #if TORCH_VERSION_NEWER_THAN(2, 8, 0) |
Contributor
There was a problem hiding this comment.
@pzhan9 Shouldn't this condition have been for 2.9.1? Even the release/2.9 branch has a 4-argument version: https://github.com/pytorch/pytorch/blob/d38164a545b4a4e4e0cf73ce67173f70574890b6/torch/csrc/autograd/input_buffer.h#L31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When running
fbpkg build //monarch:monarch_devon 3279935a10 we encounter a compile time error that seems to stem from compiling with different versions of PyTorch. We might want to update our build chain. It seems monarch is once compiled against a third part 2.8.0 pytorch and once against the fbcode version. This version guard helps with this version drift if that's intended.Reviewed By: pzhan9, zdevito, soulitzer
Differential Revision: D86363543