capture panic message inside panic_handler #1890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 14, 2025
Summary: The main motivation is by making this change, we can log panic message here too: https://www.internalfb.com/code/fbsource/[4a662228cd8bdf2bdf9b760e705cc9958f85e55c]/fbcode/monarch/hyperactor/src/panic_handler.rs?lines=47 it currently does not and caused quite some confusion for me, since I thought there is a bug in the panic catching logic. Differential Revision: D87086712
pzhan9
force-pushed
the
export-D87086712
branch
from
d315ae1 to
47c5e28
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 17, 2025
Summary: The main motivation is by making this change, we can log panic message here too: https://www.internalfb.com/code/fbsource/[4a662228cd8bdf2bdf9b760e705cc9958f85e55c]/fbcode/monarch/hyperactor/src/panic_handler.rs?lines=47 it currently does not and caused quite some confusion for me, since I thought there is a bug in the panic catching logic. Reviewed By: dulinriley, vidhyav Differential Revision: D87086712
pzhan9
force-pushed
the
export-D87086712
branch
2 times, most recently
from
649c83e to
f8e7ded
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 17, 2025
Summary: The main motivation is by making this change, we can log panic message here too: https://www.internalfb.com/code/fbsource/[4a662228cd8bdf2bdf9b760e705cc9958f85e55c]/fbcode/monarch/hyperactor/src/panic_handler.rs?lines=47 it currently does not and caused quite some confusion for me, since I thought there is a bug in the panic catching logic. Differential Revision: D87086712
pzhan9
force-pushed
the
export-D87086712
branch
from
f8e7ded to
036d37c
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: The main motivation is by making this change, we can log panic message here too: https://www.internalfb.com/code/fbsource/[4a662228cd8bdf2bdf9b760e705cc9958f85e55c]/fbcode/monarch/hyperactor/src/panic_handler.rs?lines=47 it currently does not and caused quite some confusion for me, since I thought there is a bug in the panic catching logic. Reviewed By: mariusae Differential Revision: D87086712
Summary: The main motivation is by making this change, we can log panic message here too: https://www.internalfb.com/code/fbsource/[4a662228cd8bdf2bdf9b760e705cc9958f85e55c]/fbcode/monarch/hyperactor/src/panic_handler.rs?lines=47 it currently does not and caused quite some confusion for me, since I thought there is a bug in the panic catching logic. Reviewed By: mariusae Differential Revision: D87086712
pzhan9
force-pushed
the
export-D87086712
branch
from
036d37c to
bad12cd
Compare
|
This pull request has been merged in f4deec6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The main motivation is by making this change, we can log panic message here too:
https://www.internalfb.com/code/fbsource/[4a662228cd8bdf2bdf9b760e705cc9958f85e55c]/fbcode/monarch/hyperactor/src/panic_handler.rs?lines=47
it currently does not and caused quite some confusion for me, since I thought there is a bug in the panic catching logic.
Differential Revision: D87086712