Log proc_id's pid when available #1904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There is a bug in `Instance`'s current Drop impl: https://www.internalfb.com/code/fbsource/[5b70b5b30638d5db5dfef1cbf929dea6df7d3f56]/fbcode/monarch/hyperactor/src/proc.rs?lines=1594-1596 since we clone a `Instance` object on the python side: https://www.internalfb.com/code/fbsource/[5b70b5b30638d5db5dfef1cbf929dea6df7d3f56]/fbcode/monarch/hyperactor/src/proc.rs?lines=1566 It means the Instance's actor status will be changed to `Stopped` when a clone is dropped, although the actor is still alive. This diff adds a `InstanceState` struct, so the instance's lifetime can tracked by `Arc`'s ref counter. Then we move the `Drop` impl to this `InstanceState`, so it will only be called when the ref count goes to 0. Reviewed By: dulinriley Differential Revision: D87075455
Summary: 1. Use `name = "SupervisionEvent"` so the supervision logs can be searched with this value; 2. Change log levels: `warn` for error and `debug` for others. Reviewed By: mariusae Differential Revision: D87094538
Summary: As title Reviewed By: mariusae Differential Revision: D87111325
Summary: It is useful to know which pid this proc is running on. In the long run, we probably should use hyper cli to get this info, but a log should be also good as a quick workaround. Reviewed By: mariusae Differential Revision: D87112445
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in f67f81c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It is useful to know which pid this proc is running on. In the long run, we probably should use hyper cli to get this info, but a log should be also good as a quick workaround.
Reviewed By: mariusae
Differential Revision: D87112445