Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hyperactor/src/channel/net/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,8 @@ where
.as_ref()
.map(|acked_seq| AckedSeqValue(acked_seq.clone()));

use hyperactor_telemetry::skip_record;

tracing::span!(
Level::ERROR,
"net i/o loop",
Expand All @@ -802,6 +804,7 @@ where
largest_acked = largest_acked.as_value(),
outbox = QueueValue::from(&deliveries.outbox.deque).as_value(),
unacked = QueueValue::from(&deliveries.unacked.deque).as_value(),
skip_record,
)
}

Expand Down
2 changes: 1 addition & 1 deletion hyperactor_mesh/examples/dining_philosophers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ impl Waiter {

#[tokio::main]
async fn main() -> Result<ExitCode> {
hyperactor_telemetry::initialize_logging_for_test();
hyperactor::initialize_with_current_runtime();

// Option: run as a local process mesh
// let host_mesh = HostMesh::process(extent!(hosts = 1), BootstrapCommand::current().unwrap())
Expand Down
15 changes: 15 additions & 0 deletions hyperactor_telemetry/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,21 @@ const ENV_VALUE_TEST: &str = "test";
#[allow(dead_code)]
const ENV_VALUE_LOCAL_MAST_SIMULATOR: &str = "local_mast_simulator";

/// A marker field used to indicate that a span should not be recorded as
/// individual start/end span events; rather the span is purely used to
/// provide context for child events.
///
/// Note that the mechanism for skipping span recording uses the precise
/// name "skip_record", thus it must be used as a naked identifier:
/// ```ignore
/// use hyperactor_telemetry::skip_record;
///
/// tracing::span!(..., skip_record);
/// ```
#[allow(non_upper_case_globals)]
// pub const skip_record: tracing::field::Empty = tracing::field::Empty;
pub const skip_record: bool = true;

pub mod in_memory_reader;
#[cfg(fbcode_build)]
mod meta;
Expand Down
Loading