Create hyperactor_config crate #2017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@thomasywang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87890698. |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Nov 28, 2025
Summary: Pull Request resolved: meta-pytorch#2017 We want this to be reusable from any crate without taking a dependency on `hyperactor` to avoid circular dependencies. Differential Revision: D87890698
thomasywang
force-pushed
the
export-D87890698
branch
from
0aa7d35 to
37b158d
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 1, 2025
Summary: Pull Request resolved: meta-pytorch#2017 We want this to be reusable from any crate without taking a dependency on `hyperactor` to avoid circular dependencies. Reviewed By: dulinriley Differential Revision: D87890698
thomasywang
force-pushed
the
export-D87890698
branch
from
37b158d to
ceb03db
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 1, 2025
Summary: Pull Request resolved: meta-pytorch#2017 We want this to be reusable from any crate without taking a dependency on `hyperactor` to avoid circular dependencies. Reviewed By: dulinriley Differential Revision: D87890698
thomasywang
force-pushed
the
export-D87890698
branch
from
ceb03db to
9c5ebbb
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 1, 2025
Summary: Pull Request resolved: meta-pytorch#2017 We want this to be reusable from any crate without taking a dependency on `hyperactor` to avoid circular dependencies. Reviewed By: dulinriley Differential Revision: D87890698
thomasywang
force-pushed
the
export-D87890698
branch
from
9c5ebbb to
5cd6b55
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 2, 2025
Summary: Pull Request resolved: meta-pytorch#2017 We want this to be reusable from any crate without taking a dependency on `hyperactor` to avoid circular dependencies. Reviewed By: dulinriley Differential Revision: D87890698
thomasywang
force-pushed
the
export-D87890698
branch
from
5cd6b55 to
09596dc
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 2, 2025
Summary: Pull Request resolved: meta-pytorch#2017 We want this to be reusable from any crate without taking a dependency on `hyperactor` to avoid circular dependencies. Reviewed By: dulinriley Differential Revision: D87890698
thomasywang
force-pushed
the
export-D87890698
branch
from
09596dc to
d1369b1
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 2, 2025
Summary: Pull Request resolved: meta-pytorch#2017 We want this to be reusable from any crate without taking a dependency on `hyperactor` to avoid circular dependencies. Reviewed By: dulinriley Differential Revision: D87890698
thomasywang
force-pushed
the
export-D87890698
branch
from
d1369b1 to
56e7937
Compare
Summary: We need to make `hyperactor_named` it's own crate to break a circular dependency Differential Revision: D87941210
Summary: Pull Request resolved: meta-pytorch#2017 We want this to be reusable from any crate without taking a dependency on `hyperactor` to avoid circular dependencies. Reviewed By: dulinriley Differential Revision: D87890698
thomasywang
force-pushed
the
export-D87890698
branch
from
56e7937 to
7002611
Compare
|
This pull request has been merged in 3acd912. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We want this to be reusable from any crate without taking a dependency on
hyperactorto avoid circular dependencies.Differential Revision: D87890698