Restore Port objects as argument to send #265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving around the rank logic so that the `send` API is still clean. Now every PythonMessage has a "rank: Optional[usize]" which is set for any message that is a response from a PythonActor that identifies the returning rank. The python PortReceiver object is the one that decides whether to expose the rank in the message or just return the message. Differential Revision: [D76617694](https://our.internmc.facebook.com/intern/diff/D76617694/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jun 13, 2025
Moving around the rank logic so that the `send` API is still clean. Now every PythonMessage has a "rank: Optional[usize]" which is set for any message that is a response from a PythonActor that identifies the returning rank. The python PortReceiver object is the one that decides whether to expose the rank in the message or just return the message. Differential Revision: [D76617694](https://our.internmc.facebook.com/intern/diff/D76617694/) ghstack-source-id: 290319653 Pull Request resolved: #265
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76617694 |
Moving around the rank logic so that the `send` API is still clean. Now every PythonMessage has a "rank: Optional[usize]" which is set for any message that is a response from a PythonActor that identifies the returning rank. The python PortReceiver object is the one that decides whether to expose the rank in the message or just return the message. Differential Revision: [D76617694](https://our.internmc.facebook.com/intern/diff/D76617694/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76617694 |
Contributor
|
This pull request has been merged in 7186689. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Moving around the rank logic so that the
sendAPI is still clean.Now every PythonMessage has a "rank: Optional[usize]" which is set for any message that is a response from a PythonActor that identifies the returning rank. The python PortReceiver object is the one that decides whether to expose the rank in the message or just return the message.
Differential Revision: D76617694