[8/n] Future gains result()/exception() and can be await more than once #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await). This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture. For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure _all_ blocking_impl paths take a timeout parameter, which is way more work. This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container. Differential Revision: [D76828364](https://our.internmc.facebook.com/intern/diff/D76828364/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76828364/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jun 17, 2025
Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await). This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture. For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure _all_ blocking_impl paths take a timeout parameter, which is way more work. This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container. Differential Revision: [D76828364](https://our.internmc.facebook.com/intern/diff/D76828364/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76828364/)! ghstack-source-id: 291007227 Pull Request resolved: #289
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76828364 |
…ore than once" Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await). This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture. For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure _all_ blocking_impl paths take a timeout parameter, which is way more work. This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container. Differential Revision: [D76828364](https://our.internmc.facebook.com/intern/diff/D76828364/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76828364/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jun 17, 2025
Pull Request resolved: #289 Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await). This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture. For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure _all_ blocking_impl paths take a timeout parameter, which is way more work. This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container. ghstack-source-id: 291015937 @exported-using-ghexport Differential Revision: [D76828364](https://our.internmc.facebook.com/intern/diff/D76828364/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76828364/)!
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76828364 |
…ore than once" Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await). This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture. For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure _all_ blocking_impl paths take a timeout parameter, which is way more work. This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container. Differential Revision: [D76828364](https://our.internmc.facebook.com/intern/diff/D76828364/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76828364/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jun 17, 2025
Pull Request resolved: #289 Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await). This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture. For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure _all_ blocking_impl paths take a timeout parameter, which is way more work. This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container. ghstack-source-id: 291041599 @exported-using-ghexport Differential Revision: [D76828364](https://our.internmc.facebook.com/intern/diff/D76828364/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76828364/)!
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76828364 |
…ore than once" Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await). This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture. For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure _all_ blocking_impl paths take a timeout parameter, which is way more work. This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container. Differential Revision: [D76828364](https://our.internmc.facebook.com/intern/diff/D76828364/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76828364/)! [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76828364 |
This was referenced Jun 16, 2025
…ore than once" Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await). This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture. For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure _all_ blocking_impl paths take a timeout parameter, which is way more work. This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container. Differential Revision: [D76828364](https://our.internmc.facebook.com/intern/diff/D76828364/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76828364/)! [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76828364 |
Contributor
|
This pull request has been merged in 2dd3a9d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously our ActorFuture would do weird stuff if get()/await was called more than once. Now it behaves like a normal future (records the result/exception and replay it on each get/await).
This also adds the result()/exception() method our monarch.common.Future had. This is for compat when the next PR flips the tensor engine over to ActorFuture.
For compat, we need to add timeout to result. The easiest way to achieve this is to just run it through the async path with a wait_for call. Otherwise we have to make sure all blocking_impl paths take a timeout parameter, which is way more work.
This doesn't implement done() because it isn't easy: some of our "futures" require actual work to do before they complete so they cannot be polled for done like true futures, which are just a container.
Differential Revision: D76828364
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!