[7/n] Get history ready for working with ports #278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D76649221](https://our.internmc.facebook.com/intern/diff/D76649221/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76649221/)! [ghstack-poisoned]
This was referenced Jun 13, 2025
zdevito
added a commit
that referenced
this pull request
Jun 16, 2025
Differential Revision: [D76649221](https://our.internmc.facebook.com/intern/diff/D76649221/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76649221/)! ghstack-source-id: 290606270 Pull Request resolved: #278
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76649221 |
Differential Revision: [D76649221](https://our.internmc.facebook.com/intern/diff/D76649221/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76649221/)! [ghstack-poisoned]
This was referenced Jun 18, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76649221 |
Differential Revision: [D76649221](https://our.internmc.facebook.com/intern/diff/D76649221/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76649221/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jun 18, 2025
This cleans up the history object in order to replace the message returns with direct sending to the return port. In particular, it clarifies the lifetimes of Invocation objects an Ref s by replacing the hash tables with Arc links. Now invocations live as long as there is a Ref referring to them, or if it is still in flight. Status enum make sure we do not hold users longer than needed. Pull Request resolved: #278 ghstack-source-id: 291379176 Differential Revision: [D76649221](https://our.internmc.facebook.com/intern/diff/D76649221/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76649221/)!
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76649221 |
Contributor
|
This pull request has been merged in d37217f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D76649221
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!