Edition 2024 cleanup: rename expr_2021 -> expr
#949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80508019 |
cjlongoria
force-pushed
the
export-D80508019
branch
from
4580cac to
046c3dc
Compare
cjlongoria
added a commit
to cjlongoria/monarch-1
that referenced
this pull request
Aug 25, 2025
Summary: This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Differential Revision: D80508019
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80508019 |
cjlongoria
added a commit
to cjlongoria/monarch-1
that referenced
this pull request
Aug 25, 2025
Summary: Pull Request resolved: meta-pytorch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Differential Revision: D80508019
cjlongoria
force-pushed
the
export-D80508019
branch
2 times, most recently
from
0b06d96 to
2f484b9
Compare
cjlongoria
added a commit
to cjlongoria/monarch-1
that referenced
this pull request
Aug 25, 2025
Summary: This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80508019 |
cjlongoria
added a commit
to cjlongoria/monarch-1
that referenced
this pull request
Aug 25, 2025
Summary: Pull Request resolved: meta-pytorch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019
cjlongoria
force-pushed
the
export-D80508019
branch
from
2f484b9 to
3d3918c
Compare
Summary: This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019
cjlongoria
force-pushed
the
export-D80508019
branch
from
3d3918c to
6ea1dac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80508019 |
facebook-github-bot
pushed a commit
to facebook/dotslash
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebookexperimental/hermit
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebookincubator/below
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebook/starlark-rust
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebookincubator/buck2-change-detector
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebookincubator/gazebo
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
Contributor
|
This pull request has been merged in 8b54609. |
facebook-github-bot
pushed a commit
to facebookexperimental/reverie
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to WhatsApp/erlang-language-platform
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
facebook-github-bot
pushed a commit
to facebookincubator/antlir
that referenced
this pull request
Aug 26, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Test Plan: ci Rollback Plan: Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
vmagro
pushed a commit
to facebookincubator/antlir
that referenced
this pull request
Sep 2, 2025
Summary: X-link: meta-pytorch/monarch#949 This renames `expr_2021` to `expr` for rust macros. The `expr_2021` was used during the Rust Edition upgrade to ensure compatibility between the two editions. Now that we are using Rust Edition 2024 as the default, and none of the macros are triggering a build failure with this rename, we can rename this back to `expr` Test Plan: ci Rollback Plan: Reviewed By: diliop Differential Revision: D80508019 fbshipit-source-id: 5ebdc9a11067ff66d2ec475790e9df97a6e1fa46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D80508019