Remove logger level settings #1036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Please see comments in D83398754. It is recommended set logging level at the top level only, so remove module-level debug setting in: - `early_stop_checker`, as well as avoiding the spamming of logs. - `env`, as well as changing `debug` logs to `info`, since this is usually a one-off setting in the flow, which is not supposed to spam the logs. Differential Revision: D83985240
|
@clarkdykang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83985240. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
early_stop_checker, as well as avoiding the spamming of logs.env, as well as changingdebuglogs toinfo, since this is usually a one-off setting in the flow, which is not supposed to spam the logs.Differential Revision: D83985240