Simplify seek skipping logic #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
scotts
approved these changes
Nov 11, 2025
Contributor
scotts
left a comment
scotts
left a comment
There was a problem hiding this comment.
Agreed this is better - we should try to consolidate seeking avoidance logic in canWeAvoidSeeking().
scotts
reviewed
Nov 11, 2025
| // For audio, we only need to seek if a backwards seek was requested | ||
| // within getFramesPlayedInRangeAudio(), when setCursorPtsInSeconds() was | ||
| // called. For more context, see [Audio Decoding Design] | ||
| return !cursorWasJustSet_; |
Contributor
There was a problem hiding this comment.
I believe this can now be just return true. Should the comment above it also be updated?
Contributor
Author
There was a problem hiding this comment.
I think the comment about only needing to seek when backwards is relevant.
Logically yes, we could just return true here now, but that would make the logic of this if block dependent on the existence of the previous one. I.e. if we were to change it to true and later remove the new
if (!cursorWasJustSet_) {
return true;
}then we'd be changing the behavior and that wouldn't be trivial to notice.
Actually, I might move the new condition below the audio one to avoid just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor simplification that I hope will make #1028 easier to understand.
I'm trying to explain in plain english what the simplification is doing, but anything I come up with is a lot more complicated than just looking at the code. I hope it makes sense.