Skip to content

Simplify seek skipping logic #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

Simplify seek skipping logic #1039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86ec99e
Simplify seek skipping logic
NicolasHug Nov 11, 2025
abc2cb1
Minor change
NicolasHug Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/torchcodec/_core/SingleStreamDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,11 @@ bool SingleStreamDecoder::canWeAvoidSeeking() const {
// within getFramesPlayedInRangeAudio(), when setCursorPtsInSeconds() was
// called. For more context, see [Audio Decoding Design]
return !cursorWasJustSet_;
} else if (!cursorWasJustSet_) {
// For videos, when decoding consecutive frames, we don't need to seek.
return true;
}

if (cursor_ < lastDecodedAvFramePts_) {
// We can never skip a seek if we are seeking backwards.
return false;
Expand Down Expand Up @@ -1181,10 +1185,8 @@ UniqueAVFrame SingleStreamDecoder::decodeAVFrame(

resetDecodeStats();

if (cursorWasJustSet_) {
maybeSeekToBeforeDesiredPts();
cursorWasJustSet_ = false;
}
maybeSeekToBeforeDesiredPts();
cursorWasJustSet_ = false;

UniqueAVFrame avFrame(av_frame_alloc());
AutoAVPacket autoAVPacket;
Expand Down
Loading