Skip to content

Relax tolerances for FFmpeg v4.1 and earlier #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

Relax tolerances for FFmpeg v4.1 and earlier #1045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec5407
Relax tolerances for FFmpeg v4.1 and earlier
scotts Nov 13, 2025
86b1f58
Make it 2
scotts Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test/test_transform_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
assert_frames_equal,
assert_tensor_close_on_at_least,
AV1_VIDEO,
get_ffmpeg_major_version,
get_ffmpeg_minor_version,
H265_VIDEO,
NASA_VIDEO,
needs_cuda,
Expand Down Expand Up @@ -254,7 +256,13 @@ def test_resize_ffmpeg(self):

assert frame_resize.shape == expected_shape
assert frame_ref.shape == expected_shape
assert_frames_equal(frame_resize, frame_ref)

if get_ffmpeg_major_version() <= 4 and get_ffmpeg_minor_version() <= 1:
# FFmpeg version 4.1 and before appear to have a different
# resize implementation.
torch.testing.assert_close(frame_resize, frame_ref, rtol=0, atol=2)
else:
assert_frames_equal(frame_resize, frame_ref)

def test_resize_transform_fails(self):
decoder = create_from_file(str(NASA_VIDEO.path))
Expand Down
Loading