Ensure we don't read invalid memory when seeking to pts before the first frame #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
std::round()to ensure that we go back to int64 as faithfully as possible. Previously we were truncating and that could lead to off-by-one errors.This fixes #307 (in particular, (1) fixes that)
I added a test for (1) but adding a test for (2) requires a lot of precise video editing that I haven't done.